Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Pydantic to v2 #2101

Closed
jake-skipper opened this issue Jan 3, 2024 · 1 comment · Fixed by #2518
Closed

Upgrade Pydantic to v2 #2101

jake-skipper opened this issue Jan 3, 2024 · 1 comment · Fixed by #2518
Assignees
Labels
breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. changelog:major Major change resulting in a major release feature Request or pull request for a new feature priority:high High priority issue or pull request status:accepted Issue or pull request accepted by maintainer
Milestone

Comments

@jake-skipper
Copy link
Contributor

Runway uses Pydantic extensively, and awhile back they moved to v2. We haven't received those updates due to package pinning and some changes will be required to move to v2.

@jake-skipper jake-skipper added question Further information is requested priority:low Low priority issue or pull request status:review_needed Issue or pull request needs reviewed labels Jan 3, 2024
@ITProKyle ITProKyle added priority:high High priority issue or pull request feature Request or pull request for a new feature status:accepted Issue or pull request accepted by maintainer breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. changelog:major Major change resulting in a major release and removed question Further information is requested priority:low Low priority issue or pull request status:review_needed Issue or pull request needs reviewed labels Jul 23, 2024
@ITProKyle ITProKyle added this to the v3.0.0 milestone Jul 23, 2024
@ITProKyle ITProKyle modified the milestones: v3.0.0, v2.7.0 Aug 7, 2024
@ITProKyle
Copy link
Collaborator

ITProKyle commented Aug 7, 2024

The decision was made to perform this upgrade, even though it is mildly breaking, in a minor release rather than major.

Tasks to be completed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. changelog:major Major change resulting in a major release feature Request or pull request for a new feature priority:high High priority issue or pull request status:accepted Issue or pull request accepted by maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants