Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end support for installing via cURL & npm #2508

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

ITProKyle
Copy link
Collaborator

Summary

End support for installing via cURL & npm. This enables us to upgrade to pydantic ^2 (#2101) without needed to produce pyinstaller builds per-architecture/platform.

What Changed

Changed

  • updated quickstarts/runway/Dockerfile:
    • uses ubuntu:24.04 as the base image
    • uses pyenv to install python
    • uses pipx to install runway with a not that recommends using poetry to install runway per-project instead

Removed

  • removed dependencies, documentation, files, and jobs related to pyinstaller builds
  • removed documentation, files, and jobs related to publishing to S3 for installing runway via cURL
  • removed documentation, files, and jobs related to publishing to npm

@ITProKyle ITProKyle added breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. changelog:minor Minor change resulting in a minor release labels Aug 15, 2024
@ITProKyle ITProKyle self-assigned this Aug 15, 2024
@github-actions github-actions bot added feature Request or pull request for a new feature github_actions Update to GitHub Actions javascript Pull request that updates Javascript code npm Update to npm configuration poetry Update to Poetry configuration pyinstaller python Update to Python code labels Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (1ae271f) to head (c3a47be).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2508   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         247      247           
  Lines       15610    15610           
=======================================
+ Hits        14073    14074    +1     
+ Misses       1537     1536    -1     
Files Coverage Δ
runway/core/components/_module_type.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae271f...c3a47be. Read the comment docs.

@ITProKyle ITProKyle marked this pull request as ready for review August 15, 2024 18:07
Copy link

@alexander-kogan alexander-kogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ITProKyle ITProKyle merged commit 2c00768 into master Aug 15, 2024
24 checks passed
@ITProKyle ITProKyle deleted the feat/remove-npm-and-pyinstaller branch August 15, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. changelog:minor Minor change resulting in a minor release feature Request or pull request for a new feature github_actions Update to GitHub Actions javascript Pull request that updates Javascript code npm Update to npm configuration poetry Update to Poetry configuration python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants