Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO] investigate import errors in various locations #432

Closed
ITProKyle opened this issue Aug 26, 2020 · 2 comments
Closed

[TODO] investigate import errors in various locations #432

ITProKyle opened this issue Aug 26, 2020 · 2 comments
Labels
breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. bug Something isn't working priority:medium Medium priority issue or pull request

Comments

@ITProKyle
Copy link
Collaborator

#429 moved the stacker shim to resolve some import errors and as a result causing/uncovering some other import errors.

These errors are not present during normal execution (CLI invocation). They arose in our test suite where conftest.py imports portions of runway outside of normal execution.

This error was resolved by changing this import:

from runway.config import Config
from runway.core.components import DeployEnvironment

to this and consuming the components inline (e.g. runway.config.Config()):

import runway

Looking at the error, it appears to be a cyclic import issue involving the Runway config, CFNgin lookups, hooks, variables, and exceptions (#430). To resolve this, we will need to shuffle around where things are defined which will cause things to break. notably any hook or custom module that handles exceptions or still implements in-hook variable resolution.

Since this does not impact executing Runway via the CLI (the primary intent of this project) I don't perceive this as a critical issue and can be fixed in the next scheduled major release without expediting timeline.

@ITProKyle ITProKyle added bug Something isn't working priority:medium Medium priority issue or pull request breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. labels Aug 26, 2020
@ITProKyle
Copy link
Collaborator Author

ITProKyle commented Sep 3, 2020

This appears to have been resolved by #439 and #440 but will need to test further once #429 has been merged and incorporated into the v2 branch.

These fixes can't be applied to v1.

@ITProKyle
Copy link
Collaborator Author

Updated the v2 branch after #429 was merged into master. Removed the relocated stacker shim and reverted the changes to conftest (#452). The issue did not reoccur. Closing as solved by the linked PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. bug Something isn't working priority:medium Medium priority issue or pull request
Projects
None yet
Development

No branches or pull requests

1 participant