[TODO] investigate import errors in various locations #432
Labels
breaking
Issue or PR is for a breaking change. Bug is a breaking bug with no workaround.
bug
Something isn't working
priority:medium
Medium priority issue or pull request
#429 moved the stacker shim to resolve some import errors and as a result causing/uncovering some other import errors.
These errors are not present during normal execution (CLI invocation). They arose in our test suite where
conftest.py
imports portions of runway outside of normal execution.This error was resolved by changing this import:
to this and consuming the components inline (e.g.
runway.config.Config()
):Looking at the error, it appears to be a cyclic import issue involving the Runway config, CFNgin lookups, hooks, variables, and exceptions (#430). To resolve this, we will need to shuffle around where things are defined which will cause things to break. notably any hook or custom module that handles exceptions or still implements in-hook variable resolution.
Since this does not impact executing Runway via the CLI (the primary intent of this project) I don't perceive this as a critical issue and can be fixed in the next scheduled major release without expediting timeline.
The text was updated successfully, but these errors were encountered: