Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relocate, update, and rename variable & lookup exceptions #439

Merged
merged 1 commit into from
Sep 3, 2020
Merged

relocate, update, and rename variable & lookup exceptions #439

merged 1 commit into from
Sep 3, 2020

Conversation

ITProKyle
Copy link
Collaborator

Summary

Relocate exceptions related to variables and lookups to the top level of Runway.

Why This Is Needed

resolves #430

What Changed

Changed

  • variable and lookup exceptions are now located in runway.exceptions
    • reworded some of these exceptions and changed some of the parameters & attributes
  • renamed some exceptions in runway.cfngin.exceptions to scope them to Blueprints for clarity
  • updated some type hints and converted them to modern type hints (basic type checking was used to validate but they may not pass strict type checking)
  • updated tests to use the new import locations

Fixed

Were any bugs fixed?

Removed

  • removed a redundant exception that existed to re-raise another exception without adding meaningful information

@ITProKyle
relocate, update, and rename some exceptions
68a067a 
- variable and lookup exceptions are not top level
- renamed some exceptions for more clarity
- removed a redundant exception
- update some type hints
- update tests for new import locations
@ITProKyle ITProKyle added the feature Request or pull request for a new feature label Sep 2, 2020
@ITProKyle ITProKyle self-assigned this Sep 2, 2020
@ITProKyle ITProKyle marked this pull request as ready for review September 2, 2020 22:09
@ITProKyle ITProKyle merged commit 528cb27 into rackspace:v2 Sep 3, 2020
@ITProKyle ITProKyle deleted the feature/relocate-exceptions branch September 3, 2020 15:51
@ITProKyle ITProKyle mentioned this pull request Sep 3, 2020
Closed
@ITProKyle ITProKyle added the breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. label Oct 1, 2020
ITProKyle added a commit that referenced this pull request Jan 15, 2021
@ITProKyle
relocate, update, and rename variable & lookup exceptions (#439)
a3b436a 
- variable and lookup exceptions are not top level
- renamed some exceptions for more clarity
- removed a redundant exception
- update some type hints
- update tests for new import locations
ITProKyle added a commit that referenced this pull request Feb 16, 2021
@ITProKyle
relocate, update, and rename variable & lookup exceptions (#439)
f4fe05e 
- variable and lookup exceptions are not top level
- renamed some exceptions for more clarity
- removed a redundant exception
- update some type hints
- update tests for new import locations
ITProKyle added a commit that referenced this pull request Feb 25, 2021
@ITProKyle
relocate, update, and rename variable & lookup exceptions (#439)
b35f768 
- variable and lookup exceptions are not top level
- renamed some exceptions for more clarity
- removed a redundant exception
- update some type hints
- update tests for new import locations
ITProKyle added a commit that referenced this pull request Mar 22, 2021
@ITProKyle
relocate, update, and rename variable & lookup exceptions (#439)
dc334bb 
- variable and lookup exceptions are not top level
- renamed some exceptions for more clarity
- removed a redundant exception
- update some type hints
- update tests for new import locations
@ITProKyle ITProKyle added the changelog:major Major change resulting in a major release label Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ITProKyle ITProKyle

Labels
breaking Issue or PR is for a breaking change. Bug is a breaking bug with no workaround. changelog:major Major change resulting in a major release feature Request or pull request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ITProKyle