Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add acm certificate hook #200

Merged
merged 24 commits into from
Apr 3, 2020
Merged

add acm certificate hook #200

merged 24 commits into from
Apr 3, 2020

Conversation

ITProKyle
Copy link
Collaborator

@ITProKyle ITProKyle commented Mar 19, 2020

Summary

Create & destroy a certificate in ACM with DNS validation when the domain is hosted in Route 53 in the same account the certificate is being created.

Why This Is Needed

When creating a certification in ACM with DNS validation with CloudFormation, there is a manual step involved to get a record set of the stack's events and add it to Route 53. This automates the process.

What Changed

Added

  • base hook class
  • support for handle_hooks to use functions or classes
    • classes must have a method for each stage they can be used with (e.g. pre_deploy, post_destroy)
  • altered classes for use in a hooks without introducing cyclic imports or requiring a full "create a plan, run plan, load blueprint from file, render it, etc" workflow when used in a hook
    • allows the hook to use existing logic from elsewhere
  • add hook for creating a certificate in acm using CloudFormation and validating it with Route 53

only supports creating a new cert
@ITProKyle ITProKyle added the feature Request or pull request for a new feature label Mar 19, 2020
@ITProKyle ITProKyle marked this pull request as ready for review April 2, 2020 18:22
@ITProKyle ITProKyle requested a review from troyready April 2, 2020 18:22
@troyready troyready merged commit c051efc into rackspace:master Apr 3, 2020
@ITProKyle ITProKyle deleted the feature/acm-hook branch April 3, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants