Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/remote uri path hyphen support #2013

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

mbordash2
Copy link
Contributor

@mbordash2 mbordash2 commented Oct 18, 2023

Summary

Add support for hyphens in URIs of remote source paths.

Why This Is Needed

URIs with hyphens will not work.

What Changed

Added

Unit test for hyphenated URIs

Fixed

Path URI regex updated to include -

Closes #1989

Checklist

  • Have you followed the guidelines in our Contribution Requirements?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?
  • Have you linted your code locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?
  • Have you updated documentation, as applicable?

@mbordash2 mbordash2 added the changelog:patch Patch change resulting in a patch release label Oct 18, 2023
@mbordash2 mbordash2 requested a review from a team October 18, 2023 22:55
@mbordash2 mbordash2 self-assigned this Oct 18, 2023
@github-actions github-actions bot added bug Something isn't working python Update to Python code labels Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2013 (d22095a) into master (956acd6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2013   +/-   ##
=======================================
  Coverage   90.18%   90.18%           
=======================================
  Files         247      247           
  Lines       15681    15681           
=======================================
  Hits        14142    14142           
  Misses       1539     1539           
Files Coverage Δ
runway/core/components/_module_path.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 956acd6...d22095a. Read the comment docs.

@jake-skipper jake-skipper merged commit 1fa0fb0 into master Oct 19, 2023
23 checks passed
@jake-skipper jake-skipper deleted the bugfix/remote-uri-path-hyphen-support branch October 19, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working changelog:patch Patch change resulting in a patch release python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] git repo link not working in path attribute
2 participants