Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cfngin diff output lookup resolution when stack is locked #209

Merged
merged 1 commit into from
Mar 26, 2020
Merged

fix cfngin diff output lookup resolution when stack is locked #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]
### Fixed
- `runway plan` for cfngin modules will now properly resolve output lookups when the original stack did not change
- `runway plan` for cfngin modules will now properly resolve output lookups when the original stack did not change or the reference stack is `locked: true`

## [1.5.1] - 2020-03-25
### Changed
Expand Down
4 changes: 3 additions & 1 deletion runway/cfngin/actions/diff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,10 +167,12 @@ def _diff_stack(self, stack, **_kwargs): # pylint: disable=too-many-return-stat
if not build.should_submit(stack):
return NotSubmittedStatus()

provider = self.build_provider(stack)

if not build.should_update(stack):
stack.set_outputs(provider.get_outputs(stack.fqn))
return NotUpdatedStatus()

provider = self.build_provider(stack)
tags = build.build_stack_tags(stack)

try:
Expand Down