Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prompt for deploy env when branch name is unexpected #229

Merged
merged 8 commits into from
Apr 16, 2020
Merged

add prompt for deploy env when branch name is unexpected #229

merged 8 commits into from
Apr 16, 2020

Conversation

ITProKyle
Copy link
Collaborator

Summary

When run interactively, Runway will prompt the user when an unexpected branch name is found (e.g. feature/env-prompt). Expected branch names are master those that begin with ENV-. The user has the choice to enter a deploy environment name (y at the prompt) or continue with the branch name (n at the prompt).

The prompt will also only occur during commands that are effected by running as interactive/non-interactive (CI environment variable set).

What Changed

Added

  • prompt to optionally provide an explicit deploy environment when git branch name is unexpected (e.g. feature branch) when run interactively

Changed

  • some unittest.TestCase tests are now pytest tests

@ITProKyle ITProKyle added the feature Request or pull request for a new feature label Apr 15, 2020
@ITProKyle ITProKyle requested a review from troyready April 15, 2020 22:37
@ITProKyle ITProKyle changed the title Feature/env prompt add prompt for deploy env when branch name is unexpected Apr 15, 2020
@troyready troyready merged commit 6dd6130 into rackspace:master Apr 16, 2020
@ITProKyle ITProKyle deleted the feature/env-prompt branch April 16, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request or pull request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants