Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert context.hook_data data type to dict #230

Merged
merged 1 commit into from
Apr 17, 2020
Merged

revert context.hook_data data type to dict #230

merged 1 commit into from
Apr 17, 2020

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

To support legacy uses that do not handle MutableMap until we can enforce the breaking change in the next major release.

Blueprint use case that was broken:

        ...
        template.add_resource(ssm.Document(
            'SsmDocument',
            Content=self.context.hook_data['json']],
            DocumentType='Command'
        ))

Which resulted in the following error.

ERROR:runway.cfngin.plan:<class 'troposphere.ssm.Document'>: SsmDocument.Content is <class 'runway.util.MutableMap'>, expected <class 'dict'>

What Changed

Fixed

  • cfngin hook_data is once again stored as a dict rather than MutableMap to support stacker hooks/lookups/blueprints that do not handle the MutableMap data type when consuming hook_data.

to support legacy uses that do not handle MutableMap until we can enforce the breaking change in the next major release
@ITProKyle ITProKyle added the bug Something isn't working label Apr 16, 2020
@ITProKyle ITProKyle marked this pull request as ready for review April 16, 2020 17:43
@ITProKyle ITProKyle requested a review from troyready April 16, 2020 17:43
@troyready troyready merged commit b60cc53 into rackspace:master Apr 17, 2020
@ITProKyle ITProKyle deleted the bugfix/hook_data_type branch April 17, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants