Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix npm build artifact, pypi publish artifact download, setup-node #235

Merged
merged 5 commits into from
Apr 17, 2020
Merged

fix npm build artifact, pypi publish artifact download, setup-node #235

merged 5 commits into from
Apr 17, 2020

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

  • pypi publish failed due to missing directory
  • npm package did not have the correct contents
  • npm publish is failing

What Changed

Added

  • path to artifact download when publishing to pypi

Changed

  • pyinstaller build script will now zip onefolder builds

Removed

  • trailing slash from the npm repository url when setting up node to mimic github docs in an attempt to resolve "You must be logged in to publish packages." error

@ITProKyle ITProKyle added the maintenance General repo or CI/CD upkeep label Apr 17, 2020
@ITProKyle ITProKyle requested a review from troyready April 17, 2020 19:20
@troyready troyready merged commit fc4a6a4 into rackspace:master Apr 17, 2020
@ITProKyle ITProKyle deleted the maint/fix-publishing branch April 17, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyready troyready troyready approved these changes

Assignees
No one assigned
Labels
maintenance General repo or CI/CD upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ITProKyle @troyready