Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update action trigger, add --access public to npm publish #237

Merged
merged 3 commits into from
Apr 17, 2020
Merged

update action trigger, add --access public to npm publish #237

merged 3 commits into from
Apr 17, 2020

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

  • actions are not currently being run on PRs from forks
  • npm publish is failing

What Changed

Added

  • npm publish now includes --access public

Changed

  • the cicd workflow is now triggered on PR or push to the master or release branch

@ITProKyle ITProKyle added the maintenance General repo or CI/CD upkeep label Apr 17, 2020
@ITProKyle ITProKyle requested a review from troyready April 17, 2020 20:25
@troyready troyready merged commit 76809d0 into rackspace:master Apr 17, 2020
@ITProKyle ITProKyle deleted the maint/action-trigger-and-npm branch April 17, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyready troyready Awaiting requested review from troyready

Assignees
No one assigned
Labels
maintenance General repo or CI/CD upkeep
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ITProKyle @troyready