Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use poetry-dynamic-versioning, update workflows to consolidate steps #2488

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

ITProKyle
Copy link
Collaborator

@ITProKyle ITProKyle commented Aug 9, 2024

Summary

Use the poetry-dynamic-versioning plugin to automatically set package version.
This plugin automates the use of Dunamai (what is currently used).

What Changed

Added

  • added runway.__version_tuple__ set by poetry-dynamic-versioning

Changed

  • pipx is now used instead of pip when installing poetry on the devcontainer image
    • poetry-dynamic-versioning is injected into the same venv as poetry
  • standardized the names of workflow steps and added some emoji
  • replaced the use of actions/setup-python, Gr1N/setup-poetry, and a few script steps with finleyfamily/action-setup-python
    • this is a composite action that combines setting up python, installing poetry, installing poetry plugins, installing dependencies (including caching), etc
  • consolidated actions run for pull_request_target into a single workflow
  • runway.__version__ is no longer determined at runtime. it is set by poetry-dynamic-versioning when building a release
  • default value of runway_version is now None instead of >=1.10
    • this is needed for tests to pass as __version__ is statically set to 0.0.0 outside of the build & publish workflow

Removed

  • removed version target from Makefile as it is no longer needed

@ITProKyle ITProKyle self-assigned this Aug 9, 2024
@github-actions github-actions bot added github_actions Update to GitHub Actions javascript Pull request that updates Javascript code maintenance General repo or CI/CD upkeep poetry Update to Poetry configuration python Update to Python code labels Aug 9, 2024
@ITProKyle ITProKyle marked this pull request as draft August 9, 2024 19:39
@ITProKyle ITProKyle force-pushed the maint/poetry-dynamic-versioning branch from ba37b74 to 901dece Compare August 12, 2024 15:33
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (593b2be) to head (5a33618).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
+ Coverage   90.13%   90.15%   +0.01%     
==========================================
  Files         247      247              
  Lines       15610    15610              
==========================================
+ Hits        14070    14073       +3     
+ Misses       1540     1537       -3     
Files Coverage Δ
runway/__init__.py 100.00% <100.00%> (+25.00%) ⬆️
runway/config/models/runway/__init__.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 593b2be...5a33618. Read the comment docs.

@ITProKyle ITProKyle marked this pull request as ready for review August 12, 2024 16:04
Copy link

@alexander-kogan alexander-kogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ITProKyle ITProKyle merged commit 9677b7a into master Aug 12, 2024
28 checks passed
@ITProKyle ITProKyle deleted the maint/poetry-dynamic-versioning branch August 12, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Update to GitHub Actions javascript Pull request that updates Javascript code maintenance General repo or CI/CD upkeep poetry Update to Poetry configuration python Update to Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants