LookupHandler
is now a Generic
abstract base class
#2524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
runway.lookups.handlers.base.LookupHandler
is now aGeneric
ABC
(abstract base class).Why This Is Needed
abc.ABC
can require methods to be defined by subclasses at runtime beyond just raisingNotImplimentedError
typing.Generic
can be used to improve type checkingWhat Changed
Changed
runway.lookups.handlers.base.LookupHandler
is now anABC
(abstract base class)handle
method is now decorated withabstractmethod
to ensure it is defined by subclasses beyond just raisingNotImplimentedError
runway.lookups.handlers.base.LookupHandler
is now aGeneric
LookupHandler
LookupHandler