Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pylint and astroid versions, fix linting errors #258

Merged
merged 2 commits into from
Apr 30, 2020
Merged

bump pylint and astroid versions, fix linting errors #258

merged 2 commits into from
Apr 30, 2020

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

resolves #256

What Changed

Added

  • make lint_two as there are some disables that need to be added to the cli command for python 2 liniting
    • it is done this way to avoid cluttering codebase with python 2 specific disables that would need to be cleaned up in the not to distant future

Changed

  • bumped pylint and astroid versions
  • make sync_two now changes the pinned versions of astroid and pylint so that syncing can succeed.

Fixed

  • linting errors introduced by new version of pylint

@ITProKyle ITProKyle added the dependencies Pull request that updates a dependency file label Apr 29, 2020
@ITProKyle ITProKyle marked this pull request as ready for review April 29, 2020 19:03
@ITProKyle ITProKyle requested a review from troyready April 29, 2020 19:03
@troyready troyready merged commit ab5d5ab into rackspace:master Apr 30, 2020
@ITProKyle ITProKyle deleted the maint/pylint-version branch April 30, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull request that updates a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pylint/Astroid Pipfile dependencies should be updated
2 participants