Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add py wheel package to urlshortener action #288

Merged
merged 1 commit into from
May 18, 2020

Conversation

troyready
Copy link
Contributor

Aiming to elminate errors from GH actions logs like:

Could not build wheels for boto3-stubs, since package 'wheel' is not installed.

Seen in this GH action run.

Not certain it's related to subsequent Union error -- I couldn't reproduce it in my own quick test.

Aiming to elminate errors from GH actions logs like:
```
Could not build wheels for boto3-stubs, since package 'wheel' is not installed.
```
@troyready troyready requested a review from ITProKyle May 17, 2020 00:31
@troyready troyready added the maintenance General repo or CI/CD upkeep label May 17, 2020
Copy link
Collaborator

@ITProKyle ITProKyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also remove boto3-stubs from the prod dependencies by changing the import in the script to something like this to make it more resilient.

if TYPE_CHECKING:  # only req boto3-stubs as a dev dependency
    from mypy_boto3.boto3_session import Session
    from mypy_boto3_dynamodb.service_resource import Table
else:
    Session = object
    Table = object

@troyready troyready merged commit 4a5cee1 into master May 18, 2020
@troyready troyready deleted the bugfix/add_wheel_to_urlshortener branch May 18, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General repo or CI/CD upkeep
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants