Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the friendly error when npm can't be found has returned #339

Merged
merged 1 commit into from
Jun 1, 2020
Merged

the friendly error when npm can't be found has returned #339

merged 1 commit into from
Jun 1, 2020

Conversation

ITProKyle
Copy link
Collaborator

Why This Is Needed

resolves #336

What Changed

Changed

  • .check_for_npm() is now run after all attributes are set

@ITProKyle ITProKyle added the bug Something isn't working label May 21, 2020
@ITProKyle ITProKyle marked this pull request as ready for review May 21, 2020 22:40
@ITProKyle ITProKyle requested a review from troyready May 21, 2020 22:40
@ITProKyle ITProKyle self-assigned this May 21, 2020
@troyready troyready merged commit d3fbc2d into rackspace:master Jun 1, 2020
@ITProKyle ITProKyle deleted the bugfix/no-npm-error branch June 1, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@troyready troyready troyready approved these changes

Assignees

@ITProKyle ITProKyle

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploying a serverless module without npm installed generates an exception
2 participants
@ITProKyle @troyready