Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npx runway <command> (npm) not recognized on Windows #449

Merged
merged 1 commit into from
Sep 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
### Fixed
- fixed a python 3 compatibility issue in `runway.cfngin.blueprints.testutil.YamlDirTestGenerator`
- fixed an issue causing static sites to be inaccessible when deployed to regions other than us-east-1
- fixed an issue where `npx runway <command>` (installed from npm) would not work on Windows

## [1.12.0] - 2020-09-11
### Changed
Expand Down
2 changes: 1 addition & 1 deletion npm/postinstall.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ fs.mkdir(`${moduleDir}/runway`, { recursive: true }, (err, data) => {
}
// symlink does not work for windows so we need to use a bat file
// this will overwrite the file if it already exists so no fancy error handling needed
fs.writeFile(binPath, `@"${moduleDir}/runway/runway-cli.exe %*"`, (err, data) => {
fs.writeFile(binPath, `@"${moduleDir}/runway/runway-cli.exe" %*`, (err, data) => {
if (err) throw err;
})
}
Expand Down