auth@edge: fix refreshauth error handling #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous "break" statement would cause None to be returned by the function, which refreshauth did not expect. Changing it to raise pushes the error into refresh auth so it can invalidate the token as expected. parseauth also uses this shared function, and this should also help avoid unexpected error handling in it. Cosmetically, removed the traceback logging from the http method because it didn't show anything farther up the stack than the http_post_with_retry method (just request/urllib spam)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous "break" statement would cause None to be returned by the function (after the 5 attempts failed), which refreshauth did not expect. Changing it to
raisepushes the error into refresh auth so it can invalidate the token as expected.parseauth also uses this shared function, and this should also help avoid unexpected error handling in it.
Cosmetically, removed the traceback logging from the http method because it didn't show anything farther up the stack than the
http_post_with_retry method (just request/urllib spam).
Cloudwatch Logs showing the error occurring:
