Drop CIText & update Django #237
Conversation
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 94.41% 94.44% +0.02%
==========================================
Files 107 107
Lines 4767 4791 +24
Branches 272 273 +1
==========================================
+ Hits 4501 4525 +24
Misses 223 223
Partials 43 43
Continue to review full report at Codecov.
|
|
Note: We tried to squash the migrations in a way that renders the extension obsolete for new installations, but currently we run into circular dependency errors due to a team having an owner (a member) and a member having a team. https://docs.djangoproject.com/en/4.0/topics/migrations/#squashing-migrations has some documentation on how to deal with this, but we haven't quite gotten it to work just yet. |
| """A differently-cased but otherwise same username should not be allowed registration.""" | ||
|
|
||
| self.user.username = self.admin_user.username.upper() | ||
| self.assertRaises(IntegrityError, self.user.save) |
There was a problem hiding this comment.
Similar to teams, this should 400 instead of raising an Exception
There was a problem hiding this comment.
@david-cooke this is testing the database saving part though, not the endpoint. Or do you mean that the endpoint is missing?
There was a problem hiding this comment.
Do we handle it on registration?
There was a problem hiding this comment.
There isn't really any entry point for error handling there from what I gather, so I would vote that we merge it as-is right now and wait for Sentry to throw up 🛷
No. I am not a MySQL database. I will not be writing a migration that incurs data loss. |
jchristgit
force-pushed
the
drop-citext
branch
from
0347bbd
to
f08e703
Compare
|
@thebeanogamer per your request, the migration has been altered to introduce data loss. |
`django-clacks` was removed temporarily until we figure out why poetry won't lock the dependencies with clacks included.
A unique constraint is created on the database in order to prevent duplicate signups using a name that only differs in casing for both users as well as teams. Two test cases are added to verify this behaviour.
Co-authored-by: Daniel Milnes <thebeanogamer@gmail.com>
jchristgit
force-pushed
the
drop-citext
branch
from
f08e703
to
f8717d0
Compare
* Update to Django 4.0 `django-clacks` was removed temporarily until we figure out why poetry won't lock the dependencies with clacks included. * Drop CI text fields in favour of charfields A unique constraint is created on the database in order to prevent duplicate signups using a name that only differs in casing for both users as well as teams. Two test cases are added to verify this behaviour. * Re-add django-clacks * Truncate data in migration Co-authored-by: Daniel Milnes <thebeanogamer@gmail.com> * Reject usernames with a length > 36 Co-authored-by: Daniel Milnes <thebeanogamer@gmail.com> Co-authored-by: David Cooke <me@dave.lc>
Move from CIText to plain char fields.
The created database migration updates the existing field (without incurring
any data loss, so this can be run safely) and creates the new database index
preventing the creation of team and users whose name only differs in their
case.
Closes #189.
Fixes #235.
@thebeanogamer you need to take care when rolling this out becausewe may need to adjust existing entries in the database before PostgreSQL will
accept the migration.