Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary setting causing a warning #246

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Remove unnecessary setting causing a warning #246

merged 2 commits into from
Feb 17, 2022

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Feb 17, 2022

This was changed to default to true in django 4.0 and throws a warning.

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #246 (3064bd8) into master (e0e216d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   94.45%   94.45%   -0.01%     
==========================================
  Files         107      107              
  Lines        4801     4800       -1     
  Branches      274      274              
==========================================
- Hits         4535     4534       -1     
  Misses        223      223              
  Partials       43       43              
Impacted Files Coverage Δ
src/backend/settings/__init__.py 76.25% <ø> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e216d...3064bd8. Read the comment docs.

Copy link
Member

@thebeanogamer thebeanogamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of the USE_L10N setting is changed to True. See the Localization section above for more details.

https://docs.djangoproject.com/en/4.0/releases/4.0/

@0xAda 0xAda merged commit 0a11954 into master Feb 17, 2022
@0xAda 0xAda deleted the remove-usel10n branch February 17, 2022 21:34
0xAda added a commit that referenced this pull request Sep 26, 2024
Co-authored-by: Daniel Milnes <thebeanogamer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants