Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use i18n validation everywhere #249

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Use i18n validation everywhere #249

merged 4 commits into from
Feb 17, 2022

Conversation

0xAda
Copy link
Contributor

@0xAda 0xAda commented Feb 17, 2022

A couple strings weren't in i18n format

jchristgit and others added 4 commits February 17, 2022 22:58
@jchristgit
Rely on database unique constraints
5ed9c55 
PR #245 updated the validators to check for duplicate usernames and
emails by running a query before posting the data. Let's rely on the
database indexes instead, which is more robust. This builds on top of
PR #245's tests to verify the functionality.
@0xAda
Merge branch 'master' into prevent-race-conditions-for-duplicate-names
83a6869
@0xAda
Convert a couple strings to i18n
d987369
@0xAda
Merge branch 'master' into use-i18n-validation-everywhere
c2a0768
@codecov
Copy link

codecov bot commented Feb 17, 2022 •
edited
Loading

Codecov Report

Merging #249 (c2a0768) into master (bd27043) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #249   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files         108      108           
  Lines        4969     4969           
  Branches      264      264           
=======================================
  Hits         4798     4798           
  Misses        139      139           
  Partials       32       32
Impacted Files Coverage Δ
src/authentication/basic_auth.py 100.00% <100.00%> (ø)
src/authentication/serializers.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd27043...c2a0768. Read the comment docs.

jchristgit
jchristgit approved these changes Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jchristgit jchristgit merged commit 8ad477e into master Feb 17, 2022
@jchristgit jchristgit deleted the use-i18n-validation-everywhere branch February 17, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebeanogamer thebeanogamer thebeanogamer approved these changes

@jchristgit jchristgit jchristgit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xAda @thebeanogamer @jchristgit