-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix create_user command #263
Conversation
I'm not sure why we were setting `nargs` and `const`. Setting `required` seems much more sensible. Resolves #260
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Auto-approved due to hotfix/
branch.
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 108 108
Lines 5026 5026
Branches 267 267
=======================================
Hits 4858 4858
Misses 137 137
Partials 31 31 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought these were optional?
if not options["password"]:
options["password"] = Member.objects.make_random_password(length=14)
if not options["email"]:
options["email"] = options["username"] + "@bot.ractf"
@jchristgit You are, as always, correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm not sure why we were setting `nargs` and `const`. Setting `required` seems much more sensible. Resolves #260
I'm not sure why we were setting
nargs
andconst
. Settingrequired
seems much more sensible.Resolves #260