Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create_user command #263

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Fix create_user command #263

merged 2 commits into from
Mar 6, 2022

Conversation

thebeanogamer
Copy link
Member

I'm not sure why we were setting nargs and const. Setting required seems much more sensible.
Resolves #260

I'm not sure why we were setting `nargs` and `const`. Setting `required` seems much more sensible.
Resolves #260
Copy link
Member

@RACTFBot RACTFBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Auto-approved due to hotfix/ branch.

@thebeanogamer thebeanogamer requested a review from 0xAda March 6, 2022 18:56
@thebeanogamer thebeanogamer enabled auto-merge (squash) March 6, 2022 18:57
@thebeanogamer thebeanogamer added the bug Something isn't working label Mar 6, 2022
@codecov
Copy link

codecov bot commented Mar 6, 2022

Codecov Report

Merging #263 (1f1190e) into master (8f3e616) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   96.65%   96.65%           
=======================================
  Files         108      108           
  Lines        5026     5026           
  Branches      267      267           
=======================================
  Hits         4858     4858           
  Misses        137      137           
  Partials       31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3e616...1f1190e. Read the comment docs.

Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought these were optional?

    if not options["password"]:
        options["password"] = Member.objects.make_random_password(length=14)
    if not options["email"]:
        options["email"] = options["username"] + "@bot.ractf"

@thebeanogamer
Copy link
Member Author

@jchristgit You are, as always, correct

Copy link
Collaborator

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thebeanogamer thebeanogamer merged commit 19b8cf0 into master Mar 6, 2022
@thebeanogamer thebeanogamer deleted the hotfix/create_user_command branch March 6, 2022 21:24
0xAda pushed a commit that referenced this pull request Sep 26, 2024
I'm not sure why we were setting `nargs` and `const`. Setting `required` seems much more sensible.
Resolves #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError Running Manage.py Create_User
3 participants