Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove bin.laddr #19691

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: remove bin.laddr #19691

wants to merge 1 commit into from

Conversation

trufae
Copy link
Collaborator

@trufae trufae commented Feb 12, 2022

  • It was set for a while, RBinFile holds this info in loadaddr
  • file.offset was conceptually wrong because its 'global'

Checklist

  • Closing issues: #issue
  • Mark this if you consider it ready to merge
  • I've added tests (optional)
  • I wrote some lines in the radare2book

Description

@trufae trufae added the cmdbreak The change introduces backward incompatible commands label Feb 16, 2022
@trufae trufae added this to the 5.8.0 milestone May 31, 2022
@trufae trufae changed the title Remove the file.offset unused config variable 5.8.0: Remove the file.offset unused config variable Jun 14, 2022
@trufae trufae changed the title 5.8.0: Remove the file.offset unused config variable WIP: remove bin.laddr Sep 21, 2022
@trufae trufae force-pushed the master branch 5 times, most recently from 97fe746 to 7c55e4b Compare December 22, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmdbreak The change introduces backward incompatible commands
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@trufae @radare