-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use continuous integration and define full suite of tests to validate all PR's #199
Comments
Discussed on a call today - it would be good to have a validation tool that can reference remote schemas, which isn't in place now. May be good to use the validation tool @jbants is working on. James, if you could link to the python validator from here that could help @matthewhanson get it set up. |
https://github.com/sparkgeo/stac-validator |
We also discussed that it would be ok to do this work after RC1, since it hopefully doesn't change the spec at all. If spec changes are needed we'd cut an RC2, but most likely we'd just get the validation working and maybe update examples and release 0.6.0 |
Changed to 0.6.0 Would be good to update the CI to use the stac validator (as I think it can pull in remote references), and ensure all the examples are up to date, and have that CI in place for all future dev development (so people who make PR's that change the schema need to update the examples too). And we should ensure the OpenAPI doc combining stuff is all working. Also consider doing formatting. Like #298 on the examples. We could even consider it for the markdown formatting as well... Though that should probably wait till 0.7.0 so we don't have tons of changes after RC1 |
As said in #298, it would be useful to write a script that combines the following tasks:
Not sure about Markdown formatting though. That script should be running on the CI and should also be usable by the user so that before every PR they can make sure everything is valid with a single call. Currently it includes a ton of checks that need to be done separately. We may need separate issues for them and solve this in steps, but all of this should be available eventually. |
@matthewhanson - assigning to you as you were going to make some progress on this. Feel free to redefine to be a smaller scope, and put any more todo's in their own issues. |
Thanks @scisco for doing the bulk of the work on this, and @JustinWP for having the same idea and getting it set up with Travis (may want to use some of his checks in CircleCI). He's got CircleCI set up on master and dev.
Right now it's not doing much, but is working. We likely don't want to do the full validation until we merge the major PR's and update the examples all in one go, instead of having each json schema PR update all the examples just for their change.
The text was updated successfully, but these errors were encountered: