Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection assets to core #1008

Merged
merged 6 commits into from
Feb 24, 2021
Merged

Collection assets to core #1008

merged 6 commits into from
Feb 24, 2021

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented Feb 23, 2021

Related Issue(s): #1002

Proposed Changes:

  1. Updated Collection spec to include Assets
  2. Removed Collection-level extension

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@cholmes cholmes requested a review from m-mohr as a code owner February 23, 2021 21:42
@cholmes
Copy link
Contributor Author

cholmes commented Feb 23, 2021

Ok, I think this is ready for review. @m-mohr - I hacked through schema changes, so hopefully I did them right. Thought I got myself into a failing state, but I think I figured it out. But would be good for you to check it over.

I did click on 'this is not a breaking change', because I think it is in a very small way? If implementations said collection-assets for the extension then that will fail with it gone (though that will be true for every extension we move out).

@cholmes cholmes added this to the 1.0.0-RC.1 milestone Feb 24, 2021
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of changes:

  • Remove extension from Code Owners file
  • Align collection and item spec a bit more (i.e. moved assets details to "Additional Fields Information")
  • As it was the last spec where it was missing, added h4 headers for "Additional Fields Information" in Items
  • Add assets to examples (which may conflict with Examples refresh #955, but then it reminds us to check whether there are collection assets in the examples an add them if not)
  • Added to changelog that "No change is required except removing collection-assets from the list of stac_extensions."

Please also review my changes @cholmes and feel free to change things again.

@cholmes
Copy link
Contributor Author

cholmes commented Feb 24, 2021

Cool. Just looked it over, changes look good. A couple comments:

As it was the last spec where it was missing, added h4 headers for "Additional Fields Information" in Items

I think I made these changes in another PR too, but we can just merge here and I'll deal.

Add assets to examples (which may conflict with #955, but then it reminds us to check whether there are collection assets in the examples an add them if not)

#955 got merged - I added #1013 to track this though, as I agree we need to be sure to get them in.

@cholmes cholmes merged commit 5a2d60c into dev Feb 24, 2021
@cholmes cholmes deleted the collection-assets branch February 24, 2021 20:48
@m-mohr m-mohr linked an issue Feb 24, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move collection assets extension to core
3 participants