Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples for code automatic testing #1080

Merged
merged 10 commits into from
Apr 15, 2021
Merged

Fix examples for code automatic testing #1080

merged 10 commits into from
Apr 15, 2021

Conversation

emmanuelmathot
Copy link
Collaborator

@emmanuelmathot emmanuelmathot commented Apr 1, 2021

Context:

In code libraries implementing STAC spec, a good validation exercise is to read and write the official examples of the repository. A typical test case implemented in DotNetStac is to recreate the collection example from the referenced items. To have a comprehensive validation, values in title, extent, summaries... must be aligned.

Proposed Changes:

  1. Align spatio-temporal values between items and collection in order to be able to reproduce examples from code for automatic tests validation
  2. As discussed and proposed in stac_extensions and summaries #1077 and Clarified stac_extensions #1078, include the stac_extensions corresponding to the summarized fields

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec, and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot marked this pull request as ready for review April 10, 2021 15:59
@cholmes
Copy link
Contributor

cholmes commented Apr 15, 2021

@emmanuelmathot - is this ready to go? We're looking to cut rc.3 soon.

examples/collection.json Outdated Show resolved Hide resolved
cholmes and others added 2 commits April 15, 2021 08:37
@m-mohr m-mohr merged commit bb15ca6 into dev Apr 15, 2021
@m-mohr m-mohr deleted the fix_examples branch April 15, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants