Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No multiple parents #1279

Merged
merged 31 commits into from
Jul 17, 2024
Merged

No multiple parents #1279

merged 31 commits into from
Jul 17, 2024

Conversation

emmanuelmathot
Copy link
Collaborator

@emmanuelmathot emmanuelmathot commented May 7, 2024 •
edited
Loading

Related Issue(s): #1230

Proposed Changes:

  1. Clarify unique parent link requirement
  2. Added collection relation type for link in catalog and collection
  3. Moved the STAC structural relations in common metadata spec

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@emmanuelmathot emmanuelmathot changed the title Nomultiparents No multiple parents May 7, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented May 7, 2024 •
edited
Loading

I think we only really discussed parent links so far, i.e. #1230.

I don't think this necessarily should solve #1236 and #1273. At least I'd like to discuss it first.

m-mohr
m-mohr reviewed May 7, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed May 7, 2024
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
m-mohr
m-mohr requested changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@emmanuelmathot
Copy link
Collaborator Author

This PR is set at the agenda of the next STAC meetup along with the collections discussions.

@emmanuelmathot emmanuelmathot added this to the 1.1 milestone May 14, 2024
@m-mohr m-mohr linked an issue May 14, 2024 that may be closed by this pull request
Multiple parents? #1230
Closed
@emmanuelmathot
Copy link
Collaborator Author

emmanuelmathot commented Jun 3, 2024 •
edited
Loading

Discussed in STAC meetup:

  • Single STAC parent and root in spec
  • Different encodings with same relation type
  • Leave collection out of PR

m-mohr
m-mohr reviewed Jun 27, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
m-mohr
m-mohr reviewed Jun 27, 2024
View reviewed changes
item-spec/item-spec.md Outdated Show resolved Hide resolved
@m-mohr m-mohr linked an issue Jun 27, 2024 that may be closed by this pull request
Collection links for catalogs/collections #1236
Closed
@emmanuelmathot
Copy link
Collaborator Author

emmanuelmathot commented Jul 4, 2024 •
edited
Loading

@m-mohr There was tables merge with previous PR #1259. Please make a new review.

@emmanuelmathot emmanuelmathot requested a review from m-mohr July 4, 2024 08:22
m-mohr
m-mohr reviewed Jul 11, 2024
View reviewed changes
item-spec/item-spec.md Outdated Show resolved Hide resolved
gadomski
gadomski reviewed Jul 12, 2024
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
collection-spec/collection-spec.md Outdated Show resolved Hide resolved
emmanuelmathot and others added 5 commits July 12, 2024 14:45
@emmanuelmathot
restored iri check
80dcd05
@emmanuelmathot
restored item-spec
3d5f7fa
@emmanuelmathot @gadomski
Update best-practices.md
665abf9 
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@emmanuelmathot @gadomski
Update collection-spec/collection-spec.md
04c3244 
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@emmanuelmathot
table padding
48cd8ac
m-mohr
m-mohr reviewed Jul 12, 2024
View reviewed changes
item-spec/item-spec.md Outdated Show resolved Hide resolved
emmanuelmathot and others added 7 commits July 12, 2024 23:11
@emmanuelmathot @m-mohr
Update item-spec/common-metadata.md
d8f5bb4 
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot @m-mohr
Update item-spec/common-metadata.md
f16e721 
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot @m-mohr
Update item-spec/common-metadata.md
1ece935 
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot @m-mohr
Update item-spec/common-metadata.md
f12d2d2 
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot @m-mohr
Update item-spec/common-metadata.md
0cfa0ba 
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot @m-mohr
Update item-spec/item-spec.md
ce0ca8c 
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot
Update hierarchical relations in common-metadata.md
8f16ded
@emmanuelmathot emmanuelmathot requested a review from m-mohr July 12, 2024 21:19
@emmanuelmathot emmanuelmathot merged commit b71e6e9 into dev Jul 17, 2024
2 checks passed
@m-mohr m-mohr deleted the nomultiparents branch July 31, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-mohr m-mohr m-mohr approved these changes

@gadomski gadomski gadomski approved these changes

@matthewhanson matthewhanson Awaiting requested review from matthewhanson

@cholmes cholmes Awaiting requested review from cholmes

@lossyrob lossyrob Awaiting requested review from lossyrob

@jbants jbants Awaiting requested review from jbants

Assignees

@emmanuelmathot emmanuelmathot

Labels
None yet
Projects
None yet
Milestone
1.1.0-beta.1
Development

Successfully merging this pull request may close these issues.

Collection links for catalogs/collections Multiple parents?
3 participants
@emmanuelmathot @m-mohr @gadomski