Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe ItemCollection and CollectionCollection #1290

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Describe ItemCollection and CollectionCollection #1290

merged 4 commits into from
Jul 12, 2024

Conversation

emmanuelmathot
Copy link
Collaborator

Related Issue(s): #1251

Proposed Changes:

  1. ItemCollection
  2. CollectionCollection

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG
    or a CHANGELOG entry is not required.
  • This PR affects the STAC API spec,
    and I have opened issue/PR #XXX to track the change.

@m-mohr m-mohr changed the title Dewscribe ItemCollection and CollectionCollection Describe ItemCollection and CollectionCollection Jun 27, 2024
@m-mohr
Copy link
Collaborator

m-mohr commented Jun 27, 2024

#1251 says that we actually only want to link to both specs from certain places, we won't define them in STAC core as the concepts don't exist for static catalogs. I think mentioning this without context is confusing, maybe they better go into the READMEs, not the spec document.

ItemCollection is defined in stac-api-spec, CollectionCollection has no fragment in the API yet and is only defined in the API spec's openAPI document.

@m-mohr m-mohr added this to the 1.1 milestone Jun 27, 2024
This was linked to issues Jun 27, 2024
@m-mohr m-mohr removed a link to an issue Jun 28, 2024
@emmanuelmathot
Copy link
Collaborator Author

@m-mohr sections are moved to READMEs but I am not sure to understand what you meant by context. Please review

@emmanuelmathot emmanuelmathot self-assigned this Jul 4, 2024
@emmanuelmathot emmanuelmathot marked this pull request as ready for review July 4, 2024 07:44
item-spec/README.md Outdated Show resolved Hide resolved
collection-spec/README.md Outdated Show resolved Hide resolved
Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@emmanuelmathot
Copy link
Collaborator Author

CollectionCollection defined here: radiantearth/stac-api-spec#448

Co-authored-by: Matthias Mohr <matthias@mohr.ws>
@m-mohr m-mohr merged commit 950bed9 into dev Jul 12, 2024
2 checks passed
@m-mohr m-mohr deleted the ItemCollection branch July 12, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define ItemCollection in stac-spec
3 participants