Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summaries updates - to 'strongly recommended' and with a best practice #985

Merged
merged 9 commits into from
Feb 23, 2021
Merged

Summaries updates - to 'strongly recommended' and with a best practice #985

merged 9 commits into from
Feb 23, 2021

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented Feb 10, 2021 •
edited
Loading

Related Issue(s): #820 #965

Proposed Changes:

  1. Made summaries to be 'strongly recommended' and explained them a bit more
  2. added a best practices section on summaries.

PR Checklist:

@cholmes cholmes changed the title Summaries updates Summaries updates - to 'strongly recommended' and with a best practice Feb 10, 2021
@cholmes cholmes mentioned this pull request Feb 10, 2021
Closed
philvarner
philvarner reviewed Feb 10, 2021
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
philvarner
philvarner reviewed Feb 10, 2021
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
philvarner
philvarner reviewed Feb 10, 2021
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
philvarner
philvarner reviewed Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@philvarner philvarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few wordsmithing comments, looks good!

@cholmes
Copy link
Contributor Author

cholmes commented Feb 10, 2021

Wordsmith edits incorporated, thanks!

@jisantuc jisantuc mentioned this pull request Feb 10, 2021
Closed
matthewhanson
matthewhanson reviewed Feb 11, 2021
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
m-mohr
m-mohr requested changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing to add.

m-mohr
m-mohr reviewed Feb 11, 2021
View reviewed changes
best-practices.md Outdated Show resolved Hide resolved
@cholmes @m-mohr
Update best-practices.md
6e51d33 
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
m-mohr
m-mohr approved these changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@m-mohr m-mohr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now. I think we can do the stac-fields link later, once it's stable (see #1004).

@m-mohr m-mohr mentioned this pull request Feb 23, 2021
Closed
@m-mohr m-mohr merged commit d651e4a into dev Feb 23, 2021
@m-mohr m-mohr deleted the summaries-updates branch February 23, 2021 09:33
@m-mohr m-mohr mentioned this pull request Feb 23, 2021
Closed
@schwehr schwehr mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philvarner philvarner philvarner left review comments

@jbants jbants jbants approved these changes

@m-mohr m-mohr m-mohr approved these changes

@matthewhanson matthewhanson matthewhanson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cholmes @philvarner @matthewhanson @m-mohr @jbants