Fix #5911: sirepo.resource.render_resource() #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robnagler
requested changes
Jul 10, 2023
|
@robnagler I think I addressed most of what you requested to be changed. If more, maybe this would be a good one for a software team huddle? |
|
I'd like you to re-read the comments and try to come up with more changes. |
|
ping @robnagler I think this conforms better to the resource.py module and is tailored to the service not the use. |
robnagler
requested changes
Jul 31, 2023
robnagler
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also updated sirepo.pkcli.nersc_test to use this