Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #6011: thermal transport equations and other thermal transport tab improvements #6108

Merged
merged 17 commits into from
Jul 18, 2023
Merged

Fix #6011: thermal transport equations and other thermal transport tab improvements #6108

merged 17 commits into from
Jul 18, 2023

Conversation

gurhar1133
Copy link
Contributor

No description provided.

@gurhar1133 gurhar1133 changed the title 6011 thermal transport equations Fix #6011: thermal transport equations and other thermal transport tab improvements Jul 13, 2023
@gurhar1133 gurhar1133 marked this pull request as ready for review July 13, 2023 16:26
@moellep
Copy link
Member

moellep commented Jul 18, 2023

I made a few changes:

  • moved the constant thermal equations out of the model def and into the "strings" section of the schema
  • hide values which aren't used in the selected equation

@moellep moellep enabled auto-merge (squash) July 18, 2023 19:02
@moellep moellep merged commit 44b6175 into master Jul 18, 2023
@moellep moellep deleted the 6011-thermal-transport-equations branch July 18, 2023 19:48
Benbenbenin0 added a commit that referenced this pull request Aug 3, 2023
@Benbenbenin0 @gurhar1133
@dependabot @mkeilman @rorour @moellep
Update branch (#6196)
561db7c 
* Fix #6002: old data plots dont show (#6020)

* Bump tough-cookie from 4.1.0 to 4.1.3 in /react (#6089)

* Fix #6011: thermal transport equations and other thermal transport tab improvements (#6108)

* Fix #6008: n0n2 plot (#6118)

* Fix #6125 - added stl files to _lib_file_basenames (#6126)

Co-authored-by: mkeilman <mkeilman@radiasoft.net>

* Fix #6003 #5976 wavelength, frequency and amplifier tab refactor (#6076)

* Fix #6121 - use lower() on file types to validate (#6131)

Co-authored-by: mkeilman <mkeilman@radiasoft.net>

* fix #6073: purge_non_premium needs to ignore UserDirNotFound (#6130)

* fix #6066: raydata better status icons (#6145)

* Fix #4826 check_origin: default to Tornado behavior (#6128)

* Bump semver from 6.3.0 to 6.3.1 in /react (#6097)

* Fix #6155 stateful compute test (#6156)

- pass sampleSource
- Add validation

* Fix #6147 incorrectly setting max-age (#6150)

* Bump word-wrap from 1.2.3 to 1.2.4 in /react (#6139)

* fix #6153 add genesis time dependence simulations (#6154)

* fix #5878 srw mirror plot (#6158)

* fix #6065: move save changes button (#6151)

* Fix #6113 exports to links (#6138)

* fix #6161 new openmc_data_downloader API (#6163)

* Fix #6143: silas UI collection of updates (#6152)

* fix #6144 and fix #6165 add telescope and splitter optical elements (#6168)

* fix #6144 fix #6165 silas beamsplitter, telescope element and new mirror icon

* hide crystal summary on reused crystals

* guard against null equation text

* fix #6144 added BELLA example and new plot options (#6175)

- added crystal plot "Total Number of Excited States"
 - default crystal calc_type to "analytical"
 - changed default pump_rep_rate back to 1
 - use rslaser library to compute crystal longitudinal plots

* fix #6142 implement new thermal transport simulation (#6177)

* Fix #6142: bug note

* Fix #6142: WIP

* Fix #6142: WIP

* Fix #6142: WIP

* Fix #6142: radial, longitudinal, heatmap

* for #6142 thermal crystal changes

* Fix #6142: WIP

* Fix #6142: comment out more crystal cruft

* Fix #6142: cleanup

* for #6142 fix plots units and ranges

* Fix #6142: temp profile h5

---------

Co-authored-by: git-user <git-email>
Co-authored-by: gurhar1133 <ghns1133@gmail.com>

* Fix #6184 radia stl position (#6185)

* #6184 - use bounding box to center

---------

Co-authored-by: mkeilman <mkeilman@radiasoft.net>

* fix #6133: rename job_supervisor.cfg.purge_non_premium_* (#6149)

* Fix #6023 srw watchpoint panels (#6120)

* #6023 - show watchpoint reports without data

---------
Will go ahead and merge this one

Co-authored-by: mkeilman <mkeilman@radiasoft.net>

* Fix #6180: rep rate error (#6183)

* Fix #6180: colormap

* Fix #6180: fix regex and error in ui for bad pump pulse

* Fix #6180: remove unused import

---------

Co-authored-by: Michael Keilman <30352290+mkeilman@users.noreply.github.com>

---------

Co-authored-by: Gurhar Khalsa <49498231+gurhar1133@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Michael Keilman <30352290+mkeilman@users.noreply.github.com>
Co-authored-by: mkeilman <mkeilman@radiasoft.net>
Co-authored-by: Raven <ravenmarieorourke@gmail.com>
Co-authored-by: Rob Nagler <github@q33.us>
Co-authored-by: Paul Moeller <moeller@radiasoft.net>
Co-authored-by: gurhar1133 <ghns1133@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeilman mkeilman Awaiting requested review from mkeilman

@moellep moellep Awaiting requested review from moellep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurhar1133 @moellep