-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Snowpack with Vite #26
Replace Snowpack with Vite #26
Conversation
It seems that there is a problem with |
The CI errors come from the missing up to date package-lock.json.. I did an eslint linting and no errors where thrown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
It seems like the |
I uploaded the |
src/config.json
Outdated
@@ -62,6 +62,7 @@ | |||
}, | |||
"tokens": [] | |||
}, | |||
"RADICLE_HTTP_API":"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this radicle: { api: string }
, so it matches the format of the safe config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay yeah no problem, I kept it that way to maintain the process.env
style for a eventual return to injected env vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, we can just do config.radicle.api = import.meta.env.RADICLE_HTTP_API
when that happens
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
Signed-off-by: Sebastian Martinez <sebastinez@me.com>
This PR completes #25.
It replaces Snowpack with Vite, which lets us use IDX and ceramic-js for some reason better than Snowpack.
For it to work I had to:
Since I can't compile package-lock.json without getting compile errors in the CI, I commit only package.json.
I tried all the eventual functionality and it is very similar to Snowpack in speed and configuration, to be sure I also tried different operations with IDX and it works like a charm.