This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
fix(ui): display branch a commit belongs to #1835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API now provides the branch a commit belongs to. This partially reverts #1717. The issue was not discovered because of disabled type checking due to #1798. We address this by not using the `Remote` component The motivation for #1717 was to gracefully handle commits without branches and not panic. We accomplish this by returning the (possibly empty) list of all branches and only showing the first branch (if present) in the UI. Fixes #1793 Signed-off-by: Thomas Scholtes <thomas@monadic.xyz>
rudolfs
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API now provides the branch a commit belongs to. This partially reverts #1717.
The issue was not discovered because of disabled type checking due to #1798. We address this by not using the
RemotecomponentThe motivation for #1717 was to gracefully handle commits without branches and not panic. We accomplish this by returning the (possibly empty) list of all branches and only showing the first branch (if present) in the UI.
Fixes #1793