This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
Point at patched libgit #1895
Merged
Point at patched libgit #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the toolchain need to be on par? 🤔 Or has it run out of space? |
|
Looks more like a run-out-of-space error |
I'll clear the cache |
|
I believe this is now failing due to the changes in the server sent events which are currently merged into master on link and will be fixed by #1758 , I'll get on to fixing the issues in that PR then we can revisit this. |
geigerzaehler
previously approved these changes
May 27, 2021
|
Ugh, code signing, I'll rebase and force push with a signature, at which point I think this will need a bunch more approvals. |
alexjg
force-pushed
the
alexjg/point-at-patched-git
branch
from
2d02a7a
to
cddfdba
Compare
geigerzaehler
approved these changes
May 27, 2021
|
Looks like the proxy panics on CI. |
|
I think that's not a problem, it's just the |
Also fix a number of clippy lints which were activated by the change in the rust-toolchain Signed-off-by: Alex Good <alex@memoryandthought.me>
geigerzaehler
force-pushed
the
alexjg/point-at-patched-git
branch
from
cddfdba
to
16c0f0c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to use a patched version of libgit which respects the force flag on refspecs. Without this we can lose data when replicating with an out of date peer.
I had to bump the rust-toolchain which triggered a few new lints and changed the name of some older ones so I've had to make some minor changes to the code.