This repository has been archived by the owner on Aug 1, 2022. It is now read-only.
refactor(ui): linting typescript in svelte components #847
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint-plugin-svelte3
for quite some time now and momentum has stalled, so we need to usepatch-package
to allow preprocessing)eslint
rules for TypeScript; these can be amended as we adjust to using TS in sveltesvelte-check
+ necessary tweaks to get rid of warnings & errors (some of this is in zombie org/transaction code; if we fix it now it won't bother us anymore)build.sh
typechecks before lintingFlex.svelte
Going forward, I will be writing new components in TypeScript and converting existing ones gradually - please feel free to ask for help if you run into a lot of type errors or need a 🦆.
Closes #801