feat: refactor ShowClient to LibreTime v2 live-info API #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hairmare
force-pushed
the
feat/direct-libretime-integration
branch
4 times, most recently
from
7586952
to
8ad5920
Compare
hairmare
force-pushed
the
feat/direct-libretime-integration
branch
from
8ad5920
to
42d7e04
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor
ShowClientto target the LibreTime v2 live-info JSON API directly instead of using the wrapper described in #12.Introduces
requeststo make handling web requests easier with more abstraction.With this, test-coverage of the
nowplaying/show/client.py:updatefunction is now up to 100%.Issues