-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade otelhttp to v0.37.0 #5515
Conversation
Test Results2 514 tests ±0 2 507 ✔️ ±0 1m 57s ⏱️ +2s Results for commit 86a9f0b. ± Comparison against base commit 42a6f1b. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Should we have an issue to track the work of upgrading back to the latest version once the |
There is no benefit to upgrade pkg in the near future since their spec is constantly changing. As I left the comment here, it is better to wait until otelhttp has client side metric features. So I did not create new issue to upgrade it. |
The old version misses status code attribute in http request which is required for our dashboard. So we decide to use the latest version with the workaround. In this case, we need to upgrade pkg as soon as the issue fixes. @vinayada1 will create the issue apart from https://github.com/project-radius/radius/issues/5308#issuecomment-1534984679 Closing this PR. |
Description
There is the bug in otelhttp to use request.RemoteAddr for attributes, which results in high cardinality of the port of remoteaddr. This PR is to use the latest known good release.
open-telemetry/opentelemetry-go-contrib#3765
Issue reference
#5299
#5237
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: