Add temporary login for expired auth #7491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7491 +/- ##
=======================================
Coverage 63.82% 63.82%
=======================================
Files 417 417
Lines 23497 23497
=======================================
Hits 14997 14997
Misses 7229 7229
Partials 1271 1271 ☔ View full report in Codecov by Sentry. |
sk593
force-pushed
the
update-LRT-azlogin
branch
2 times, most recently
from
165cacc
to
ac60ef8
Compare
Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593
force-pushed
the
update-LRT-azlogin
branch
from
ac60ef8
to
b19758d
Compare
kachawla
approved these changes
Apr 11, 2024
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
This was referenced Apr 11, 2024
sk593
added a commit
that referenced
this pull request
Apr 11, 2024
# Description Minor update to azure cli login in LRT: #7491 Adding this step to run always in case previous steps fail ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius #7490 . <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #issue_number Signed-off-by: sk593 <shruthikumar@microsoft.com>
This was referenced Apr 12, 2024
sk593
added a commit
that referenced
this pull request
Apr 15, 2024
# Description Long-running tests have started to fail due to the az login authentication expiring. Based on the error message (see linked issue), the authentication is only valid for 5 minutes. This seems to be a known issue [based on discussion here](Azure/azure-cli#28708 (comment)) but there's no fix so adding this temporary workaround until there's a way to extend the time the auth is valid. ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius #7490 <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #issue_number Signed-off-by: sk593 <shruthikumar@microsoft.com>
sk593
added a commit
that referenced
this pull request
Apr 15, 2024
# Description Minor update to azure cli login in LRT: #7491 Adding this step to run always in case previous steps fail ## Type of change <!-- Please select **one** of the following options that describes your change and delete the others. Clearly identifying the type of change you are making will help us review your PR faster, and is used in authoring release notes. If you are making a bug fix or functionality change to Radius and do not have an associated issue link please create one now. --> - This pull request fixes a bug in Radius and has an approved issue (issue link required). - This pull request adds or changes features of Radius and has an approved issue (issue link required). - This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius #7490 . <!-- Please update the following to link the associated issue. This is required for some kinds of changes (see above). --> Fixes: #issue_number Signed-off-by: sk593 <shruthikumar@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Long-running tests have started to fail due to the az login authentication expiring. Based on the error message (see linked issue), the authentication is only valid for 5 minutes. This seems to be a known issue based on discussion here but there's no fix so adding this temporary workaround until there's a way to extend the time the auth is valid.
Type of change
Fixes: #issue_number