RSC compatibility #2923
RSC compatibility #2923
Conversation
vladmoroz
requested review from
benoitgrelard,
andy-hook and
lucasmotta
as code owners
vladmoroz
requested review from
StephenHaney and
hadihallak
and removed request for
benoitgrelard and
andy-hook
vladmoroz
force-pushed
the
vlad/rsc-compat
branch
from
74b220e
to
934278a
Compare
| React.useEffect(() => { | ||
| if (typeof window !== 'undefined') { | ||
| (window as any)[Symbol.for('radix-ui')] = true; | ||
| }, []); | ||
| } |
There was a problem hiding this comment.
Note this change, this is to allow simple primitives to be server components (like AccessibleIcon)
No context for how it's used in the original PR, but seems benign to do the assignment in render:
#853
| container?: HTMLElement | null; | ||
| container?: Element | null; |
There was a problem hiding this comment.
Corresponds to the type expected by React.createPortal
| const { container = globalThis?.document?.body, ...portalProps } = props; | ||
| const { container: containerProp, ...portalProps } = props; | ||
| const [mounted, setMounted] = React.useState(false); | ||
| useLayoutEffect(() => setMounted(true), []); | ||
| const container = containerProp || (mounted && globalThis?.document?.body); |
There was a problem hiding this comment.
When a container isn't provided, we must render twice to avoid hydration errors
vladmoroz
force-pushed
the
vlad/rsc-compat
branch
3 times, most recently
from
96d0a99
to
1d07a66
Compare
vladmoroz
force-pushed
the
vlad/rsc-compat
branch
from
1d07a66
to
edfe14d
Compare
| useLayoutEffect(() => setMounted(true), []); | ||
| const container = containerProp || (mounted && globalThis?.document?.body); |
There was a problem hiding this comment.
From an end-user point-of-view don't we introduce an extra frame as React will not render the content at first execution but after a second render cycle?
There was a problem hiding this comment.
Actually users can still pass the container to globalThis?.document?.body to drop that extra frame. Forget about my comment
for rsc compat radix-ui/primitives#2923
'use client'in key places