fix: Input attrs not reactive

[ParasSolanki]

Fixes: #224

[ParasSolanki]

Do i have to run pnpm build:registry command?
I am using Windows laptop so seeing inconsistency in registry output. #181

[sadeghbarati]

No, no need to build the registry on your end

[sadeghbarati]

I have thought about props and attrs. Please share your thoughts, too 🙏

---

attrs way

I think making read-only Proxy (useAttrs, $attrs) reactive is not a good idea

We are using computed or maybe toRefs for attrs to make them reactive/can-be-mutated inside the Component, which they can't, we are changing their nature (readonly)

---

props way

By adding class to props, class will be removed from $attrs object so we will not get duplicated class so we can use props.class in cn function and v-bind="$attrs" without worrying about duplication

Even though we are not changing/mutating some props like class (toRefs/computed) inside the Component

I think using props is a better way.

Sorry for my bad English. I'll try to make a Vue SFC Playground example to explain what I meant

#35

[ParasSolanki]

Yeah i also think using Props is a better approach here. Created a playground for it.

Vue SFC Playground

Sorry for the late response.

[sadeghbarati]

Just changed one thing in your playground, also thanks for your comment

Vue SFC Playground

Let's fake imagine class type changes in the feature so using this type from Vue (HTMLAttributes['class']) will save us refactoring tons of Components Props

- class?: string
+ class?: HTMLAttributes['class']

[ParasSolanki]

Yeah this is right way to do the typing. I should've used the HTMLAttributes['class'].

[ParasSolanki]

Now, Should i change my implementation to using Props for class? Or there are still some scenarios or edge cases we want to check first?

[sadeghbarati]

Yes, go with Props

Please, if you have time, refactor all the components

[ParasSolanki]

Yeah, okay.
And by all you mean FormItem, PaginationEllipsis and other components where we are using useAttrs for class?

[sadeghbarati]

Yes, only useAttrs 🙏

I'll refactor the rest if it's needed

[ParasSolanki]

Change the implementation to using props for class. Let me know if there are any other issue.