Retroactively Update Backup Log #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of only updating the locally stored log of old backups when the user has backups turned on and we discover that no backup is present, this PR will make it so that we always update the log. This ensures that we don't show the
Out-of-date backup still present on iCloudwarning if the user manually deletes iCloud content from settings.How to test
Out-of-date backup still present on iCloudis visibleVideo
The scenario from How to test:
cloudKitDeletion.mov
What happens if you delete the backup from within the app
inAppDeletion.mov
PR submission checklist