[ABW-3261] Display all resource metadata fields #1186
Conversation
# Conflicts: # RadixWallet.xcodeproj/project.pbxproj # RadixWallet.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
| var allMetadataItems = Set(item.metadata.items) | ||
| if let nextCursor = item.metadata.nextCursor { | ||
| // Only fetch metadata if there is more after the first page returned. | ||
| let remaining = try await gatewayAPIClient.fetchEntityMetadata(item.address, ledgerState: response.ledgerState, nextCursor: nextCursor) | ||
| allMetadataItems.append(contentsOf: remaining) | ||
| } |
There was a problem hiding this comment.
Not 100% sure about this, this will increase the overall loading times of the Wallet. Ideally the metadata should be fetched only when going in the Resource Details.
There was a problem hiding this comment.
Actually it wasn't increasing the overall loading times, since we only fetch the actual resource when we try to open its details. Before that, we are actually requesting state/entity/details for the accounts (not the resources), and in such case we don't have any item.metadata.nextCursor (as it only fetches the explicit metadata of the resources inside the accounts).
However, I pushed a new commit that explicitly requests the metadata only when requested. It adds some noise, so let me know if you prefer which version you prefer.
There was a problem hiding this comment.
Almost true. We are fetching the resource details outside of Resource Details screen for the resources that are either part of staking or pool units, see fetchPoolAndStakeUnitsDetails or when categorising resources to pool units, stake units, nft claims.
...res/AssetsFeature/Components/HelperViews/ArbitraryDataField/ArbitraryDataField+Helpers.swift
Show resolved
Hide resolved
Jira ticket: ABW-3261
Jira ticket: ABW-2863
Description
How to test
You can create a new test token under
Dev preferences, which will create aSTARtoken with 37 metadata fields.If you want to test pagination with a resource that has more than 1 page of metadata, let me know and I can send you an NFT with that.
Screenshots