[ABW-3642] Associated Resources in Approved dApps #1258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3652
Description
We should be showing associated tokens and NFTs for dApps, whether showing the dApp from a transaction or the list of approved dApps. It turned out that we filtered them out because the
dapp_definitions
metadata item was parsed in the wrong way, causing it to always appear to be empty. Specifically, the item is sent as a string collection, rather than a collection ofglobalAddress
, which is what we expected.There was also a slight update to the visual appearance of the NFT details screen, to make it work better when showing only a resource, without the individual token.
Notes
Since the item
dapp_definition
is being sent as aglobalAddress
, it might seem that the fix should be on the Gateway side, for consistency, but this PR will make things work as expected.How to test
Screenshot
PR submission checklist