Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onDisappear in AccountDetails #1275

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Remove onDisappear in AccountDetails #1275

merged 1 commit into from
Aug 9, 2024

Conversation

kugel3
Copy link
Contributor

@kugel3 kugel3 commented Aug 8, 2024

Description

We had an onDisappear that caused a runtime warning. Its purpose was to cancel portfolio fetching that was in flight when leaving the AccountDetails screen, but it does not actually do that, so this PR removes it.

@kugel3 kugel3 requested a review from danvleju-rdx August 8, 2024 16:32
@kugel3 kugel3 merged commit a4c860e into main Aug 9, 2024
6 checks passed
@kugel3 kugel3 deleted the runtime-warnings branch August 9, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants