[ABW-3581] Inform users when signing with Ledger without P2PLinks #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyonAlexRDX
reviewed
Sep 17, 2024
GhenadieVP
requested changes
Sep 19, 2024
| return .none | ||
| } | ||
| return .run { send in | ||
| for try await isConnected in await ledgerHardwareWalletClient.isConnectedToAnyConnectorExtension() { |
There was a problem hiding this comment.
I don't think this is what we should check. This can return false if there are P2PLinks, but these are not connected(you browser is closed), I believe that the intention was to inform users when there are no P2PLinks at all.
There was a problem hiding this comment.
right, will update it to check if there are any p2pLinks instead.
Do we want to leave it this way when adding a new Ledger device? Because in such case we will show this alert if there is no active connection, and user could be lead to add a new one when all they need to do is open their browser
GhenadieVP
added
the
DO NOT MERGE
GhenadieVP
removed
the
DO NOT MERGE
GhenadieVP
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3581
Description
Inform users when they attempt to access a Ledger factor source but the wallet isn't connected to any connector extension.
Also, improves the UX by removing a glitch where the ledger name wouldn't show up for an instant.
Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-16.at.16.48.58.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-16.at.17.32.04.mp4