[ABW-3869] Fix crash when transferring multiple NFTs from same collection #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasbzurovski
commented
Oct 7, 2024
Comment on lines
+7029
to
+7030
| shellScript = "# Custom linter to avoid using Dictionary.init(uniqueKeysWithValues:)\n# Quick solution before considering using an external tool, such as SwiftLint \n\nPATTERN=\"uniqueKeysWithValues:\"\nFILES=$(grep -rnw --include=\\*.swift \"$PATTERN\" \"$SRCROOT\")\n\nif [ ! -z \"$FILES\" ]; then\n echo \"Error: We shouldn't use Dictionary(uniqueKeysWithValues:), as it could lead to unhandled crashes if key is repeated\"\n echo \"Instead, use our custom init(keysWithValues:), or consider refactoring your solution to use IdentifiedArrayOf\"\n echo \"Please fix on the following files:\"\n echo \"$FILES\"\n exit 1 \nfi\n"; | ||
| }; |
There was a problem hiding this comment.
Definitely not as great as SwiftLint, but we would need some time in order to integrate such tool (and define the rules that we want to include, asides this custom one). This simple script (that takes 0.1 seconds to run) will help prevent issues as this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-3869
Description
This PR fixes a crash caused by attempting to add multiple values with same
Keyto a dictionary. The solution for this particular case required adding a new wrapper model to useIdentifiedArrayOf<>instead.Still, the PR adds a custom throwing init for
DictionaryandOrderedDictionaryto at least catch these potential failures in other situations.Video
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-07.at.16.46.38.mp4