Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABW-3913] Pre validate the expiration of PreAuthorization requests #1380

Merged
merged 3 commits into from
Nov 11, 2024

bump sargon

cc39c3f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

[ABW-3913] Pre validate the expiration of PreAuthorization requests #1380

bump sargon
cc39c3f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Xcode test results succeeded Nov 8, 2024 in 0s

Xcode test results

Testing project RadixWallet with scheme Radix Wallet Dev

Summary

TotalSuccess PassedFailure FailedSkipped SkippedExpected Failure Expected Failure⏱️ Time
1521520003.62s

Test Summary

RadixWalletTests

  • Device: iPhone 16 Pro Max, 18.0 (22A3351)
  • SDK: Simulator - iOS 18.0, 18.0
TestTotalSuccessFailureSkippedExpected Failure
test-class AccountDetailsFeatureTests22000
test-class AccountPreferencesTests11000
test-class AppFeatureTests44000
test-class AssetTransferDepositRuleTests1212000
test-class CacheClientTests22000
test-class CustomizeFeePayerTests11000
test-class DataChannelClientTests99000
test-class DataChannelMessageEncodingDecodingTests44000
test-class DataExtensionTests1111000
test-class DataToHexStringTests22000
test-class DiskPersistenceClientTests11000
test-class EntitiesHidingTests99000
test-class FactorSourcesClientLiveTests11000
test-class FaucetClientTests77000
test-class GatewaySettingsFeatureTests88000
test-class HexStringToDataTests33000
test-class IdentifiedArrayOfTests11000
test-class ImportLegacyWalletClientTests22000
test-class ImportMnemonicTests33000
test-class KeychainClientTests11000
test-class KeychainHolderTests22000
test-class LedgerModelTests44000
test-class MainFeatureTests22000
test-class NewConnectionTests33000
test-class OnLedgerEntitiesClientTests11000
test-class ROLAClientTests88000
test-class SecureStorageClientTests99000
test-class SessionStorageTests11000
test-class SettingsViewStateTests11000
test-class SignalingClientTests99000
test-class SortedTests11000
test-class SplashFeatureTests22000
test-class TokenPriceCientTests1111000
test-class TransactionClientTests1111000
test-class ValidationExtraTests11000
test-class ValidationTests11000
test-class PreAuthorizationReviewTests11000

Failure Failures

All tests passed 🎉

Code Coverage

Coverage Covered Executable
Radix Wallet.app 6.19 % 6260 101185
  AccountDepositPreValidationDecidingFactorsResourceSpecificDetailsItem.swift 0.00 % 0 13
  ValidatorCollectionItemEffectiveFeeFactorPending.swift 0.00 % 0 9
  FactoryReset+Reducer.swift 0.00 % 0 73
  StateEntityNonFungiblesPageRequest.swift 0.00 % 0 17
  Stage1MigrateToSargon+Header.swift 0.00 % 0 3
  Stage2MigrateToSargon+SharedPersonaData.swift 0.00 % 0 195
  KeychainHolder.swift 57.66 % 64 111
  MigratedHardwareAccounts.swift 0.00 % 0 25
  PreAuthorizationModels.swift 0.00 % 0 8
  SargonSecureStorageDriver.swift 13.98 % 13 93
  App+View.swift 0.00 % 0 96
  URLButtonStyle.swift 0.00 % 0 21
  AccountLockerNotFoundError.swift 0.00 % 0 11
  JSONValue.swift 29.37 % 42 143
  ErrorQueue+Live.swift 49.15 % 29 59
  RoleKey.swift 0.00 % 0 9
  Selection+Extra.swift 0.00 % 0 8
  StreamTransactionsResponse.swift 0.00 % 0 13
  CodableHelper.swift 0.00 % 0 28
  DefaultValueDecodable.swift 15.79 % 3 19
  DeveloperDisclaimerBanner.swift 0.00 % 0 32
  ImportMnemonic.swift 29.40 % 162 551
  ImportMnemonicControllingAccounts+View.swift 0.00 % 0 197
  GatewayInfoResponseReleaseInfo.swift 0.00 % 0 11
  NFTHelperViews.swift 0.00 % 0 62
  RadixConnectMobile.swift 0.00 % 0 26
  PersonaFeature.swift 0.00 % 0 33
  FactorSourceAccess+View.swift 0.00 % 0 153
  ManualAccountRecoveryCoordinator+View.swift 0.00 % 0 317
  NonFungibleResourcesCollectionItem.swift 0.00 % 0 39
  AddressDetails.swift 0.00 % 0 174
  DerivePublicKeys+View.swift 0.00 % 0 49
  TransactionFee.swift 69.57 % 128 184
  NativeResourceAccountOwnerBadgeValue.swift 0.00 % 0 7
  Persona+PreviewValues.swift 0.00 % 0 6
  AssetResourceDetails.swift 0.00 % 0 250
  ScanMultipleOlympiaQRCodes.swift 0.00 % 0 83
  HTTPURLSessionResponse.swift 15.00 % 3 20
  EventsItem.swift 0.00 % 0 11
  StateKeyValueStoreKeysResponse.swift 0.00 % 0 15
  CustomizeFees+View.swift 0.00 % 0 406
  ScanQRCoordinator+Reducer.swift 67.12 % 49 73
  HomeCardsClient+Live.swift 0.00 % 0 85
  ConfirmSkippingBDFS.swift 0.00 % 0 10
  EntitySchemaCollection.swift 0.00 % 0 11
  ScanQR+View.swift 0.00 % 0 160
  SecureStorageClient+Interface.swift 56.72 % 38 67
  StateAccountLockersTouchedAtResponseItem.swift 0.00 % 0 11
  NormalFeesCustomization.swift 100.00 % 3 3
  Login+View.swift 0.00 % 0 314
  InfoLinkSheet+Reducer.swift 0.00 % 0 104
  HitTargetSize.swift 0.00 % 0 40
  KeychainClient+Mocked.swift 7.69 % 2 26
  AddressDetails+View.swift 0.00 % 0 393
  P2P+RTCOutgoingMessage.swift 0.00 % 0 12
  ImportOlympiaNameLedger.swift 0.00 % 0 62
  FungibleResourcesCollectionItemVaultAggregatedVaultItem.swift 0.00 % 0 11
  Stage2MigrateToSargon+RadixConnectModels+Logic.swift 0.00 % 0 152
  ResourceAmount.swift 5.51 % 7 127
  Identifiable+RawRepresentable.swift 0.00 % 0 4
  Stage2MigrateToSargon+Gateways.swift 0.00 % 0 28
  ImportMnemonicControllingAccounts.swift 0.00 % 0 194
  ReceivingAccount+Reducer.swift 0.00 % 0 93
  PersonaList+Reducer.swift 0.00 % 0 141
  TextStyleModifier.swift 0.00 % 0 69
  TransactionHistoryClient+Mock.swift 0.00 % 0 12
  EntitiesVisibilityClient+Test.swift 16.67 % 2 12
  AddLedgerFactorSource.swift 0.00 % 0 197
  EditPersona.swift 0.00 % 0 324
  NewConnection+Reducer.swift 60.11 % 220 366
  DappInteractionClient+Test.swift 0.00 % 0 7
  StateKeyValueStoreKeysResponseItem.swift 0.00 % 0 9
  ComponentEntityRoleAssignments.swift 0.00 % 0 9
  StreamTransactionsRequestEventFilterItem.swift 0.00 % 0 11
  MetadataBoolArrayValue.swift 0.00 % 0 9
  ThirdPartyDeposits+Reducer.swift 0.58 % 1 172
  ResourceHoldersRequest.swift 0.00 % 0 11
  Selection.swift 0.00 % 0 372
  IOSSecurityClient+Interface.swift 0.00 % 0 5
  FeaturesPreviewer.swift 0.00 % 0 67
  RestoreProfileFromBackupCoordinator+View.swift 0.00 % 0 33
  MetadataNonFungibleGlobalIdArrayValueAllOfValues.swift 0.00 % 0 9
  TwoWayLinkedEntitiesCollectionItem.swift 0.00 % 0 7
  ImportMnemonic+View.swift 0.00 % 0 685
  NonFungibleAssetRow+View.swift 0.00 % 0 280
  IncomingMessage.swift 63.10 % 53 84
  NativeResourceGlobalCallerResourceValue.swift 0.00 % 0 7
  DappInteractionCoordinator.swift 0.00 % 0 141
  FungibleResourceAsset+Reducer.swift 0.00 % 0 166
  StateEntitySchemaPageRequest.swift 0.00 % 0 13
  Completion.swift 0.00 % 0 11
  CoreAPI_StringPlaintextMessageContent.swift 0.00 % 0 3
  LinearGradients.swift 0.00 % 0 52
  BootstrapClient+Live.swift 100.00 % 15 15
  StateNonFungibleLocationRequest.swift 0.00 % 0 11
  HideResource+View.swift 0.00 % 0 119
  ResourceBalance+Helpers.swift 0.00 % 0 127
  AccountPortfoliosClient+Mock.swift 0.00 % 0 10
  AccountWithInfo.swift 57.14 % 4 7
  LedgerHardwareWalletClient+Live.swift 0.00 % 0 521
  AccountWithInfoHolder.swift 16.67 % 1 6
  Olympia.swift 0.00 % 0 6
  TransactionReviewGuarantees+View.swift 0.00 % 0 281
  PersonaDetails+View.swift 0.00 % 0 623
  Date+Extension.swift 0.00 % 0 9
  InsecureRandomNumberGeneratorWithSeed.swift 0.00 % 0 31
  Home+View.swift 0.00 % 0 397
  DebugKeychainTest+View.swift 0.00 % 0 232
  CameraPermission+Reducer.swift 1.18 % 1 85
  CoreAPI_BinaryPlaintextMessageContent.swift 0.00 % 0 3
  Measure+Position.swift 0.00 % 0 72
  MetadataU32ArrayValue.swift 0.00 % 0 9
  Splash+View.swift 0.00 % 0 101
  TransactionHistoryClient+Interface.swift 0.00 % 0 22
  ResetWalletClient+Interface.swift 100.00 % 5 5
  DataChannelAssembledMessage.swift 100.00 % 112 112
  EditPersonaField.swift 0.00 % 0 168
  DisplayName+NonEmptyString.swift 0.00 % 0 6
  Stage1MigrateToSargon+Persona.swift 0.00 % 0 5
  AccountsClient+Test.swift 0.00 % 0 28
  CustomizeFees.swift 86.71 % 261 301
  DappInteractionLoading.swift 0.00 % 0 262
  ComponentEntityRoleAssignmentEntryAssignment.swift 0.00 % 0 9
  StreamTransactionsRequest.swift 0.00 % 0 39
  

Details

Test Details

RadixWalletTestsback

AccountDetailsFeatureTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

AccountPreferencesTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.07s

All tests passed 🎉

AppFeatureTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.05s

All tests passed 🎉

AssetTransferDepositRuleTests back

SuccessFailureSkippedExpected Failure⏱️
12 (100%)0 (0%)0 (0%)0 (0%)0.10s

All tests passed 🎉

CacheClientTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.03s

All tests passed 🎉

CustomizeFeePayerTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.53s

All tests passed 🎉

DataChannelClientTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

DataChannelMessageEncodingDecodingTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

DataExtensionTests back

SuccessFailureSkippedExpected Failure⏱️
11 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

DataToHexStringTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

DiskPersistenceClientTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

EntitiesHidingTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

FactorSourcesClientLiveTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

FaucetClientTests back

SuccessFailureSkippedExpected Failure⏱️
7 (100%)0 (0%)0 (0%)0 (0%)0.08s

All tests passed 🎉

GatewaySettingsFeatureTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.03s

All tests passed 🎉

HexStringToDataTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

IdentifiedArrayOfTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

ImportLegacyWalletClientTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.25s

All tests passed 🎉

ImportMnemonicTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.40s

All tests passed 🎉

KeychainClientTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

KeychainHolderTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

LedgerModelTests back

SuccessFailureSkippedExpected Failure⏱️
4 (100%)0 (0%)0 (0%)0 (0%)1.77s

All tests passed 🎉

MainFeatureTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.05s

All tests passed 🎉

NewConnectionTests back

SuccessFailureSkippedExpected Failure⏱️
3 (100%)0 (0%)0 (0%)0 (0%)0.03s

All tests passed 🎉

OnLedgerEntitiesClientTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.05s

All tests passed 🎉

ROLAClientTests back

SuccessFailureSkippedExpected Failure⏱️
8 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SecureStorageClientTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

SessionStorageTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

SettingsViewStateTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SignalingClientTests back

SuccessFailureSkippedExpected Failure⏱️
9 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SortedTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

SplashFeatureTests back

SuccessFailureSkippedExpected Failure⏱️
2 (100%)0 (0%)0 (0%)0 (0%)0.03s

All tests passed 🎉

TokenPriceCientTests back

SuccessFailureSkippedExpected Failure⏱️
11 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

TransactionClientTests back

SuccessFailureSkippedExpected Failure⏱️
11 (100%)0 (0%)0 (0%)0 (0%)0.02s

All tests passed 🎉

ValidationExtraTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.01s

All tests passed 🎉

ValidationTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

PreAuthorizationReviewTests back

SuccessFailureSkippedExpected Failure⏱️
1 (100%)0 (0%)0 (0%)0 (0%)0.00s

All tests passed 🎉

View more details on GitHub Actions