Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ABW-1868] Replace factor source based counters with entityIndex #602

Merged
merged 14 commits into from
Aug 14, 2023
Merged

[ABW-1868] Replace factor source based counters with entityIndex #602

merged 14 commits into from
Aug 14, 2023

Conversation

CyonAlexRDX
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX marked this pull request as draft July 5, 2023 06:56
@CyonAlexRDX CyonAlexRDX requested review from GhenadieVP and kugel3 July 5, 2023 14:16
@CyonAlexRDX CyonAlexRDX marked this pull request as ready for review July 5, 2023 14:16
@CyonAlexRDX CyonAlexRDX added the DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs label Jul 5, 2023
@CyonAlexRDX
Copy link
Contributor Author

I'm marking this as DO NOT MERGE because we have agreed to merge and 100% finalize Persona data format first. So @maciek-rdx s work with Persona data (UI/CAP21) might also change Persona data format a bit:

So after Persona Data work has been finalized, iOS and Android should be able to share the same profile_snapshot.json test vector, parseable by both platforms. AFTER that I suggest you merge this PR.

@maciek-rdx maciek-rdx self-assigned this Jul 7, 2023
@maciek-rdx maciek-rdx changed the title [ABW-1868] Replace factor source based counters with entityIndex (BLOCKED BY ABW-1817) [ABW-1868] Replace factor source based counters with entityIndex Jul 7, 2023
@CyonAlexRDX CyonAlexRDX changed the title (BLOCKED BY ABW-1817) [ABW-1868] Replace factor source based counters with entityIndex [ABW-1868] Replace factor source based counters with entityIndex Aug 14, 2023
@CyonAlexRDX CyonAlexRDX added SIGNING Signing has changed. Team MUST rigorously test. PROFILE and removed DO NOT MERGE Merging is blocked or prohibited due to missing specs or other higher priority PRs labels Aug 14, 2023
@CyonAlexRDX CyonAlexRDX mentioned this pull request Aug 14, 2023
Merged
@CyonAlexRDX CyonAlexRDX requested a review from maciek-rdx August 14, 2023 11:41
@CyonAlexRDX
Copy link
Contributor Author

Tested and verified working, 9min long video mostly of me rambling, but with recording proving it works as expected with Import Legacy Accounts: https://drive.google.com/file/d/122RgW2KqvhzUiviNzfanvL7qw23U2vIm/view?usp=sharing

GhenadieVP
GhenadieVP approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@GhenadieVP GhenadieVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@CyonAlexRDX CyonAlexRDX merged commit d8ff27a into main Aug 14, 2023
@CyonAlexRDX CyonAlexRDX deleted the ABW-1868_remove_factor_source_based_entity_counters branch August 14, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciek-rdx maciek-rdx maciek-rdx approved these changes

@GhenadieVP GhenadieVP GhenadieVP approved these changes

@kugel3 kugel3 Awaiting requested review from kugel3

Assignees
No one assigned
Labels
SIGNING Signing has changed. Team MUST rigorously test.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyonAlexRDX @GhenadieVP @maciek-rdx