Release/rcnet v2 #639
Merged
Release/rcnet v2 #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Maciek Czarnik <maciek.czarnik@rdx.works> Co-authored-by: Gustaf Kugelberg <123396602+kugel3@users.noreply.github.com> Co-authored-by: radixbot <41908264+radixbot@users.noreply.github.com> Co-authored-by: kugel3 <gustaf.kugelberg@rdx.works> Co-authored-by: Maciek <137085416+maciek-rdx@users.noreply.github.com>
Co-authored-by: rvelaz <raul.velaz@rdx.works> Co-authored-by: Ghenadie Vasiliev-Pusca <ghenadie.vasiliev-pusca@rdx.works>
Co-authored-by: Ghenadie Vasiliev-Pusca <ghenadie.vasiliev-pusca@rdx.works>
…-ios into release/rcnet-v2
Co-authored-by: Maciek Czarnik <maciek.czarnik@rdx.works>
GhenadieVP
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira tickets:
Description
This is a shared effort to adopt the new Persona Data format across all the supported use cases.
Notes
Initially, I started on my own, but quickly I realized that the effort necessary is a bit bigger than expected. Both @kugel3 and @GhenadieVP jumped in to help deliver it under the deadline which we did in the end! It's actually more than that. Due to time pressure, we ended up including the #630 here and a bunch of other fixes and improvements as well (see commit history).
The goal of this PR is to raise awareness of the most critical issues that we didn't caught during testing, and clean up the code as much as reasonably possible and merge it ASAP to
mainto start working on the v3.How to test
It has been tested in the process of release, but some testing may still be carried on based on test scenarios related to particular tickets.
PR submission checklist