ABW-1695 Pool Unit asset type #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add real image for the resource
Align the borders around tokens and nfts
Align views
Use green color for Ready to Claim
maciek-rdx
commented
Aug 7, 2023
| import FeaturePrelude | ||
|
|
||
| // MARK: - PoolUnit | ||
| public struct PoolUnit: Sendable, FeatureReducer { |
There was a problem hiding this comment.
Looks like a mild overengineering, but wanted to follow the convention of other assets 🤷🏼♂️
GhenadieVP
reviewed
Aug 7, 2023
Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/File.swift
Outdated
Show resolved
Hide resolved
Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/File.swift
Show resolved
Hide resolved
...eatures/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUComponentView.swift
Show resolved
Hide resolved
...eatures/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUComponentView.swift
Show resolved
Hide resolved
...eatures/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUResource+View.swift
Outdated
Show resolved
Hide resolved
...eatures/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUComponentView.swift
Outdated
Show resolved
Hide resolved
...eatures/AssetsFeature/Components/PoolUnitsList/Components/LSUResource/LSUResource+View.swift
Show resolved
Hide resolved
Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit+View.swift
Outdated
Show resolved
Hide resolved
Sources/Features/AssetsFeature/Components/PoolUnitsList/Components/PoolUnit/PoolUnit+View.swift
Show resolved
Hide resolved
GhenadieVP
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: ABW-1695
Description
This PR brings the UI and TCA infrastructure for later integration with the service layer.
Notes
All the data is mocked, marked with
// FIXME. Localization is also marked that way, should be fixed as soon as we merge this PR that currently fails to build.How to test
Open app, go to account and select Pool Units. Expand and collapse LSU view.
Video
RPReplay_Final1691409127.MP4
PR submission checklist